search

eprbell / dali-rp2

DaLI (Data Loader Interface) is a data loader and input generator for RP2 (https://pypi.org/project/rp2), the privacy-focused, free, open-source cryptocurrency tax calculator: DaLI removes the need to manually prepare RP2 input files. Just like RP2, DaLI is also free, open-source and it prioritizes user privacy.
https://pypi.org/project/dali-rp2/
Apache License 2.0
62 stars 41 forks source link

Forex monkey patch #236

Closed macanudo527 closed 1 month ago

macanudo527 commented 2 months ago

What?

Fixes #234

It skips pricing from the web of native fiat transactions that might be inputted with some plugins. It assigns a spot price of 1.

This adds CSV pricing for forex which will later be refactored.

eprbell commented 1 month ago

@macanudo527, is this ready for review? I see there is a small static analysis failure and wanted to check with you before starting to review. Thanks!

macanudo527 commented 1 month ago

This is just a temporary monkey patch to get it to work, so please just ignore it. I'll delete it as soon as I get a proper PR together. I just need to fine tune the new forex plugin and clean it up so it is compatible with your PR.

Its going to be a pretty big PR, but I'll try to break out the commits so it is easy to see/review.

macanudo527 commented 1 month ago

225 Will replace this.