Basic spanish support

[Larision]

Basic support to Spain country, Open_positions, full_tax_report and a copied us_tax_report. I will try do an expecific spanish_tax_report but hard to me code it. ill try do my best...

[Larision]

es.tax_report_es is supposed to be an accountant friendly report: something that Spanish tax professional would immediately be able to recognize and use (currently it mimics the US form 8949, which doesn't reflect Spanish taxes). So I think you have two options: rewrite it as described above, or remove it altogether for now and leave it for future development (you can remove it from es.py, function get_report_generators).

Removed tax_report_es Spain dont have any accountant friendly tax form so better i remove report.

update the documentation (look for "japan" or "jp" and add a Spain-specific snippet)

Checking and adding it

Thank you

[Larision]

• to fix the documentation check error in CI: can you just update your code? I fixed it and you just need to pick up the latest version of the code;

can you help me a bit more? what code i need update?

[eprbell]

• to fix the documentation check error in CI: can you just update your code? I fixed it and you just need to pick up the latest version of the code;

can you help me a bit more? what code i need update?

• to fix the documentation check error in CI: can you just update your code? I fixed it and you just need to pick up the latest version of the code;

can you help me a bit more? what code i need update?

Basically you need to bring the latest changes from the main branch into your branch: take a look at https://stackoverflow.com/questions/59916041/how-to-update-a-branch-with-master-on-github

[Larision]

• to fix the documentation check error in CI: can you just update your code? I fixed it and you just need to pick up the latest version of the code;

can you help me a bit more? what code i need update?

Basically you need to bring the latest changes from the main branch into your branch: take a look at https://stackoverflow.com/questions/59916041/how-to-update-a-branch-with-master-on-github

my repo is already synced with yours. checked twice. im lost with this :(

[eprbell]

• to fix the documentation check error in CI: can you just update your code? I fixed it and you just need to pick up the latest version of the code;

can you help me a bit more? what code i need update?

Basically you need to bring the latest changes from the main branch into your branch: take a look at https://stackoverflow.com/questions/59916041/how-to-update-a-branch-with-master-on-github

my repo is already synced with yours. checked twice. im lost with this :(

Sorry, my bad! I had disabled the Twitter link check in DaLI, but not in RP2: I just fixed it now. Can you sync one more time? It should pick up the documentation link fix and also the open_positions fix. Let me know if you have any problems.

[Larision]

• after this PR is merged, could you add a ES plugin to DaLI as well (again, you can see the DaLI Japanese plugin as a guide)? It's trivial to implement, but it has a big impact because it makes DaLI available to Spanish users.

Already done, but i have same problem with template and € symbol i had here in rp2 with open_positions

[eprbell]

• after this PR is merged, could you add a ES plugin to DaLI as well (again, you can see the DaLI Japanese plugin as a guide)? It's trivial to implement, but it has a big impact because it makes DaLI available to Spanish users.

Already done, but i have same problem with template and € symbol i had here in rp2 with open_positions

I'm not seeing a PR in DaLI about this: can you upload it?

[Larision]

• after this PR is merged, could you add a ES plugin to DaLI as well (again, you can see the DaLI Japanese plugin as a guide)? It's trivial to implement, but it has a big impact because it makes DaLI available to Spanish users.

Already done, but i have same problem with template and € symbol i had here in rp2 with open_positions

I'm not seeing a PR in DaLI about this: can you upload it?

I was waiting this PR close to upload it

[Larision]

Looks pretty good! One thing I noticed is that transaction types are not translated in rp2_full_report output. I fixed that in the latest version (see b8294df).

To get the fix you need to sync the code again, then regenerate localization strings and the translations for transaction types.

Synced, regenerated and tested, not working in transaction type neither in taxable event direction/type column.

[Larision]

msgid "USD"
msgstr "USD"

msgid "USD Total"
msgstr "Total en USD"

Should i change USD for EUR?

[eprbell]

msgid "USD"
msgstr "USD"

msgid "USD Total"
msgstr "Total en USD"

Should i change USD for EUR?

Yes, good catch.