search

eprints / eprints3.4

EPrints 3.4 core and releases
http://www.eprints.org/uk/index.php/eprints-3-4/
GNU Lesser General Public License v3.0
31 stars 28 forks source link

Clear "rows" on multiple MetaField::Compound fields #368

Open drn05r opened 9 months ago

drn05r commented 9 months ago

Most MetaField::Compound fields tend to have multiple values (i.e. rows). If a compound field has lots of subfields, having to delete all the values on a row is annoying. This is a particular problem if a repository uses the orcid_support_advance plugin as this disables the ORCID sub-field. Therefore, if a user realises they have added the wrong creator/editor they cannot delete the ORCID. Although the plugin will unset or update the ORCID field based on the ID (e.g. email) field for creators/editors this is not apparent in the user interface. Also, up until recently (not fix yet available in a released version) orcid_support's cgi/users/lookup/name has AND-ed the ORCID in the lookup, making it impossible to find any creator/editor other than the one previously entered.

It should be fairly simple to added a cross icon next to the existing up/down arrows that will clear the adjacent row. This would make it quicker to edit multiple compound fields and also avoid any confusion to the user about what metadata will be saved to the record, where disabled sub-fields exist.

dgc commented 9 months ago

Doing this in JavaScript is trivial: just delete the row element in the DOM and the EPrints workflow code will sort it out from there.

drn05r commented 4 months ago

Although the change may be trivial the impact could be large and therefore a lot of edge cases may need testing. I think this is best left to the next release.