Small fixes & reworked trigger

eprints / orcid_support_advance

ORCID Support Advance plugin

1 stars 6 forks source link

Small fixes & reworked trigger #22

Closed dennmuel closed 5 years ago

dennmuel commented 5 years ago

Hey @wfyson,

some non-fancy, minor quick fixes:

Give conference publications a "part-of" ISBN
Remove some code that doesn't seem to be needed anymore (sorry, some automatic whitespace stuff done by my editor slipped in there, too)
Add quick check before adding the putcode subfield

Edit: Also the somewhat fancy reworked pre-commit-trigger, see comment below.

Best regards

dennmuel commented 5 years ago

Hey @wfyson ,

just added an attempt at reworking the pre commit trigger to make it configurable, if it should delete or keep ORCID iDs that have been added via the normal "orcid support" plugin.

With the putcode field now beeing checked in this trigger (e.g. when the order of creators changes - thanks again for your work on this!) I think we can now no longer go on with the trigger beeing commented out by default.

Also the trigger now combines creators and editors in the sense that they are still processed seperately, but there's only one trigger to maintain.

Could you please have a look?

Best regards

wfyson commented 5 years ago

Hi @dennmuel Thanks for these updates and sorry it took me so long to get around to them - they all looked good to me so I merged them with the master branch and all of the changes have now been published on the Bazaar as version 1.5. (I added your name to the list of contributors, but unfortunately had to add it as Muller as opposed to Müller due to a bug with the Bazaar!). Thanks once again for all your help with this and Happy New Year!

dennmuel commented 5 years ago

Hi @wfyson, thank you very much! No hard feelings about taking your time and the name bug - I'm kinda used to that ;) I'm glad that I could contribute to the plugin. Thanks for your patience and help and a happy new year to you, too!