Import from orcid.org : contributors with no ORCID ID

eprints / orcid_support_advance

ORCID Support Advance plugin

1 stars 6 forks source link

Import from orcid.org : contributors with no ORCID ID #27

Closed cziaarm closed 4 years ago

cziaarm commented 5 years ago

Hello,

https://github.com/eprints/orcid_support_advance/blob/master/lib/plugins/EPrints/Plugin/Screen/ImportFromOrcid.pm#L775

Precludes the ingest of contributors (eg co-authors) that do not have an ORCID. Would it be OK if name only was ingested for non-ORCID co-authors? If so I'll put together a suitable PR

Rory

zuphilip commented 5 years ago

Sounds good for me. CC @wfyson Maybe you can then also fix the spacing problems in the following lines (tabs vs. spaces) to make the code easier to read.

wfyson commented 5 years ago

Yeah that all sounds sensible to me!