Manage/Create ORCID permissions screen HTML title

It looks like the current phrases result in an tag inside the tag for the "Manage ORCID Permissions" screen? I see this as the tab title: <img referrerpolicy="no-referrer" src="https://user-images.githubusercontent.com/4087478/180509655-76db9570-d2e8-4d06-b506-d4912b89074c.png" alt="image" /> That's because there is this in the title tag: <code><title>ORCID logoManage ORCID Permissions -...</title></code> There is a title phrase that includes an image, and that's an alt text of it. I don't think that would ever work, the way to get the icon to show up on the tab would be for the favicon to change for that page. A <title> tag, as far as I understand, only takes text.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/photomedia"><img src="https://avatars.githubusercontent.com/u/4087478?v=4" />photomedia</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>I believe this is the phrase that ends up in the title tag, but it doesn't work because title ends up with text only, no tags. <a href="https://github.com/eprints/orcid_support_advance/blob/dd18186aac77f5187971f65be9e9aee69a183e98/lib/lang/en/phrases/z_orcid_support_advance.xml#L84">https://github.com/eprints/orcid_support_advance/blob/dd18186aac77f5187971f65be9e9aee69a183e98/lib/lang/en/phrases/z_orcid_support_advance.xml#L84</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/photomedia"><img src="https://avatars.githubusercontent.com/u/4087478?v=4" />photomedia</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>I overwrote these two phrases as follows to solve the issue:</p> <pre><code><epp:phrase id="Plugin/Screen/ManageOrcid:title">Manage ORCID Permissions</epp:phrase> <epp:phrase id="Plugin/Screen/ManageOrcid:orcid/connect">Connect to ORCID</epp:phrase></code></pre> <p>This phrase shows up in the HTML title, and on the menu bar. The "Connect to ORCID" also had a trademark symbol, which I didn't think was helpful so I removed that too. It created an imbalance in the menu anyway to have that ORCID logo in the menu system, as no other link has that in the menu. The "Create/connect to ORCID" button still has the logo, so that's sufficient, IMO, and it resolves the HTML title issue. This is a simple enough customization, but perhaps worth considering for the plugin default config.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

eprints / orcid_support_advance

Manage/Create ORCID permissions screen HTML title #67