eprintsug / DataCiteDoi

Registration of DOIs via DataCite
GNU General Public License v3.0
2 stars 5 forks source link

Allow mapping functions to fallback if no value is present #18

Closed cziaarm closed 6 years ago

cziaarm commented 6 years ago

In this loop: https://github.com/eprintsug/DataCiteDoi/blob/master/lib/plugins/EPrints/Plugin/Export/DataCiteXML.pm#L62-L68

A vvalue must exist before a mapping function is called. This means that there is no way to cascade through EPrints field until here is a suitable candidate for the Datacite element.

eg If eprint.creators is not set then use eprint.corp_creators (when making a datacite.Creator)

Delegate all the value checking to the mapping subs so that they can be modified to introduce the ability to cascade through Eprints metadata where appropriate.

ghost commented 6 years ago

@cziaarm @BorysFeldman and I agreed that both creators and corp_creators should be added to creators ... currently corp_creators is not processed. So not so much a fallback as a concatenation.

cziaarm commented 6 years ago

closed by fd41e34efc7cc00a529c8f45ad22bb2b376d7768