eprintsug / rioxx2

Support for the RIOXX 2.0 Application Profile
4 stars 5 forks source link

Invalid mapping of license field #34

Open jesusbagpuss opened 9 years ago

jesusbagpuss commented 9 years ago

From:https://github.com/eprintsug/rioxx2/blob/3e029db43748e1d28bdc3e599ffc1801a61ddf6c/cfg/cfg.d/zz_rioxx2.pl#L229-L239

This maps the EPrints namedset values 'cc_by' etc. to v4 licences. I don't think this is valid. In the most recent release of EPrints, there are cc_by_4 values that should be mapped. As I understand it, license versions are NOT transmutable.

NB For a while, the labels in EPrints (in the workflow) didn't match the rendered output (one being v2.5, the other v3). IMO EPrints should be storing the licences as URIs (I may look at creating a Bazaar package that includes all CC licences, and suitable render phrases, and allows something like <field ref="license" options="v4"/> in the workflow).

jesusbagpuss commented 9 years ago

Also, there are two licences that aren't covered by the current plugin (see: http://www.rioxx.net/schema/v2.0/rioxx/ali_1_0.html#license_ref or http://rioxx.net/guidelines/RIOXX_Metadata_Guidelines_v_3.0.pdf, page 8):

Also relates to #26

jesusbagpuss commented 6 years ago

EPrints currently ships with: https://github.com/eprints/eprints/blob/3.3/lib/defaultcfg/namedsets/licenses (v3 and v4).

Also, this; https://github.com/eprintsug/rioxx2/blob/3e029db43748e1d28bdc3e599ffc1801a61ddf6c/cfg/cfg.d/zz_rioxx2.pl#L448-L458 should be updated to pass-through the value if it an http/s URI.

fatchild commented 2 years ago

This is still an issue in 3.4

Pub router contains the correct mapping... https://bazaar.eprints.org/1127/1/epm/pubrouter_rioxx_importer/cfg/cfg.d/zzz_pubrouter_rioxx_importer.pl

$c->{rioxx2}->{license_map} = {
        cc_by_nd        => "http://creativecommons.org/licenses/by-nd/3.0",
        cc_by           => "http://creativecommons.org/licenses/by/3.0",
        cc_by_nc        => "http://creativecommons.org/licenses/by-nc/3.0",
        cc_by_nc_nd     => "http://creativecommons.org/licenses/by-nc-nd/3.0",
        cc_by_nc_sa     => "http://creativecommons.org/licenses/by-nd-sa/3.0",
        cc_by_sa        => "http://creativecommons.org/licenses/by-sa/3.0",
        cc_public_domain=> "http://creativecommons.org/publicdomain/zero/1.0/legalcode",
        cc_gnu_gpl      => "http://www.gnu.org/licenses/gpl.html",
        cc_gnu_lgpl     => "http://www.gnu.org/licenses/lgpl.html",
    cc_by_nd_4      => "http://creativecommons.org/licenses/by-nd/4.0",
        cc_by_4         => "http://creativecommons.org/licenses/by/4.0",
        cc_by_nc_4      => "http://creativecommons.org/licenses/by-nc/4.0",
        cc_by_nc_nd_4   => "http://creativecommons.org/licenses/by-nc-nd/4.0",
        cc_by_nc_sa_4   => "http://creativecommons.org/licenses/by-nd-sa/4.0",
        cc_by_sa_4      => "http://creativecommons.org/licenses/by-sa/4.0",
};