eprovst / wrap

A Fountain export tool with some extras...
GNU General Public License v3.0
62 stars 8 forks source link

Fix DualDialogue lines being ignored by PDF line count #40

Closed briand27 closed 4 years ago

briand27 commented 4 years ago

Description of the change

With DualDialogue the lines were ignored by the overall line count in the PDF compiler. I believe this came from an oversight where the number of left and right lines that were written in DualDialogue were not being kept track of. I have attempted to remedy this with a simple +1 to the appropriate left or right line counts whenever a line is added with styleLine.

Benefits

The bottom margin on pages with DualDialogue should now maintain their proper 1-inch margin.

Possible drawbacks

I am not sure if line.leading() should also be added to this account, I have not studied the code base enough to know what that variable does.

Applicable issues

eprovst commented 4 years ago

Thanks!

The leading should be taken into account, I also clarified the change in the comments. Closing this now :slightly_smiling_face: