search

eproxus / meck

A mocking library for Erlang
http://eproxus.github.io/meck
Apache License 2.0
811 stars 231 forks source link

Swap in a newer rebar binary so meck can build #124

Closed CADBOT closed 9 years ago

CADBOT commented 10 years ago

The included binary doesn't work as it's too old.

eproxus commented 10 years ago

Which version of Rebar is this and which Erlang version was used to build it?

CADBOT commented 10 years ago

Erlang R14B04 rebar 2.2.0 R14B04 20140425_092605 git 2.2.0-58-g837df64

Thanks for taking a look, and let me know if you need any more info!

eproxus commented 10 years ago

In which scenarios doesn't the included Rebar work?

eproxus commented 10 years ago

The reason I'm a bit vary including this is because it is a unknown binary from a third party. I can rebuild it myself using Erlang R15B03-1. If you you have compelling reasons to use R14B04 I can try to build it using that version (that Erlang version didn't compile out of the box on OSX 10.9 though).

lucafavatella commented 10 years ago

@eproxus I am not sure why @CADBOT stated "The included binary doesn't work", but regarding the Erlang version used for compiling the rebar binary R14 or R15 I think the main difference is that a rebar binary compiled with R15 could not work with an R14 runtime (new opcodes).

BTW I am not sure whether recent meck supports R14 as it is not tested on Travis https://github.com/eproxus/meck/blob/2eb19524a0cf33a0fc67fed766679c93d363ceee/.travis.yml#L5-L9

edgurgel commented 10 years ago

Why not just remove rebar from the repository? People should install it from rebar/rebar repository or using homebrew or anything else. Maybe just point the rebar version that meck is being supported.

eproxus commented 10 years ago

I had it removed for some time, but it was added back because people couldn't handle it. Right now, the Makefile also "needs" a local Rebar binary (it could use one on the path, but that would require people to install Rebar first).