Allow hiding 'on_load' attribute.

eproxus / meck

A mocking library for Erlang

http://eproxus.github.io/meck

Apache License 2.0

811 stars 231 forks source link

Allow hiding 'on_load' attribute. #131

Closed rlipscombe closed 9 years ago

rlipscombe commented 9 years ago

See #130.

eproxus commented 9 years ago

Hi, thank you so much for the PR. I'm not really a fan of the name hide_on_load. I have two other options, which one do you like the best?

disable_on_load (defaults to true)
backup_on_load (defaults to false)

I particularly like the second one because it also signals that it has something to do with the backup modules.

rlipscombe commented 9 years ago

I prefer the first one. I don't think that people writing the test particularly care about backup or not. They just don't want on_load to be called.

Except that {disable_on_load, false} is a double-negative. Maybe enable_on_load, default to false?

eproxus commented 9 years ago

Agree, double-negatives are bad. Would you mind changing to enable_on_load?

eproxus commented 9 years ago

Again, thanks a lot!

rlipscombe commented 9 years ago

No problem.