search

eproxus / meck

A mocking library for Erlang
http://eproxus.github.io/meck
Apache License 2.0
811 stars 231 forks source link

References to hamcrest yield dialyzer warnings #218

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

While doing rebar3 as test dialyzer, which will eventually include meck in its analysis, I get warnings for references to hamcrest: types (which are outside the scope of the analysis, since hamcrest is not imported).

Would you be OK if I (PR) removed references to those types replacing them with an appropriate name and content?

e.g.

HamcrestMatcher :: hamcrest:matchspec().

would become

HamcrestMatcher :: record(). % hamcrest:matchspec().

(since there really is no strong link between the two anymore)

paulo-ferraz-oliveira commented 3 years ago

I'm preemptively pushing a PR for this, since I've found some free time.

paulo-ferraz-oliveira commented 3 years ago

Unfortunately there's also functions from hamcrest being called, which kind of makes the PR pointless (even though we can still use it).