eproxus / meck

A mocking library for Erlang
http://eproxus.github.io/meck
Apache License 2.0
811 stars 231 forks source link

Isolate hamcrest #220

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

I started this after discussing this and that, as a means to isolate hamcrest.

I ended up:

eproxus commented 3 years ago

This looks good. This makes xref and dialyzer emit no Hamcrest-related warnings?

paulo-ferraz-oliveira commented 3 years ago
➜  meck git:(fix/isolate_hamcrest) rebar3 xref             
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling meck
===> Running cross reference analysis...
➜  meck git:(fix/isolate_hamcrest)

(i.e. rebar3 xref = no warnings)

paulo-ferraz-oliveira commented 3 years ago
➜  meck git:(fix/isolate_hamcrest) rebar3 dialyzer                       
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling meck
===> Dialyzer starting, this may take a while...
===> Add debug_info to compiler options (erl_opts) if Dialyzer fails to load Core Erlang.
===> Updating plt...
===> Resolving files...
===> Checking 272 files in _build/default/rebar3_23.1.2_plt...
===> Doing success typing analysis...
===> Resolving files...
===> Analyzing 11 files with _build/default/rebar3_23.1.2_plt...
➜  meck git:(fix/isolate_hamcrest) 

(i.e. rebar3 dialyzer = no warnings)

paulo-ferraz-oliveira commented 3 years ago

Want me to add this to GitHub Actions?

paulo-ferraz-oliveira commented 3 years ago

I've added it to GitHub Actions' workflow: 487949e. Let me know if you want this reverted.

paulo-ferraz-oliveira commented 3 years ago

@eproxus, anything preventing this from being merged? Do you want me to change anything?

paulo-ferraz-oliveira commented 3 years ago

Ping.

eproxus commented 3 years ago

Thanks a lot!