search

eproxus / meck

A mocking library for Erlang
http://eproxus.github.io/meck
Apache License 2.0
811 stars 231 forks source link

R16A preview - parameterized modules are no longer supported #94

Closed norton closed 11 years ago

norton commented 11 years ago

I briefly checked if meck can build or not with a preview version of R16A. Parameterized modules will be going away soon. Have you any ideas so far on how to handle this test case? delete it, define macro, etc.

meck/test/meck_test_parametrized_module.erl:1: parameterized modules are no longer supported
meck/test/meck_test_parametrized_module.erl:6: variable 'Var1' is unbound
meck/test/meck_test_parametrized_module.erl:7: variable 'Var2' is unbound

erl --version
Erlang R16A (erts-5.10) [source] [64-bit] [smp:2:2] [async-threads:10] [kernel-poll:false]

Eshell V5.10  (abort with ^G)
1>
eproxus commented 11 years ago

The "proper" thing to do would be to macro it, but in this case I think it's safe to remove it. Would you mind making a pull request for this?

norton commented 11 years ago

See this pull request (https://github.com/eproxus/meck/pull/95).

On a similar note, I also noticed that meck's README says that agner is the recommended way to install meck. I believe agner is now deprecated and no longer supported.

eproxus commented 11 years ago

Merged #95.

eproxus commented 11 years ago

I changed README.md to recommend just using rebar for now in 7f26c19c68d8f264d6cee0905420304b1d15bb24.