eps1lon / dom-accessibility-api

Implements https://w3c.github.io/accname/
MIT License
101 stars 29 forks source link

`computeAccessibleName` won't compute button name from child title #1016

Open Cipscis opened 11 months ago

Cipscis commented 11 months ago

Elements with the "button" role support determining their accessible name from their content, and it's possible for internal elements to have no text content but instead specify their accessible name via a "title" attribute. For example:

<button>
    <span title="Name from child title"></span>
</button>

This can come up, for example, when using internal elements that display an icon.

Unfortunately, calling computeAccessibleName on such a button returns an empty string, whereas it should return 'Name from child title'. The correct title can be viewed, for example, in the accessibility tree of Chrome devtools:

image image

Calling computeAccessibleName on the inner element returns the correct accessible name.

I've set up a replication in Codepen: dom-accessibility-api accessible name bug reproduction

neaumusic commented 10 months ago

Yep having this same issue -- check out a hackernews 'upvote' button/link, you'll notice the title is not included in the computed accessible name nor description

I think https://github.com/eps1lon/dom-accessibility-api/pull/1020 might resolve the issue