search

eps1lon / dom-accessibility-api

Implements https://w3c.github.io/accname/
MIT License
101 stars 29 forks source link

feat: update WPT usage #1032

Open jlp-craigmorten opened 7 months ago

jlp-craigmorten commented 7 months ago

Resolves #1045

Updates the WPT submodule and tests.

jsdom

For the jsdom suite, i've included a (non-exhaustive) set of specs that are relevant to this package in their scope regarding accessible name, description, and role calculation:

The current status of the WPT coverage is:

Passing Failing Skipped
177 127 297

Where "Skipped" includes a combination of both relevant and irrelevant tests, but for a practical test runtime it is pragmatic to skip instead of having an expected failure.

I have opted to equate a null return from this package (e.g. from getRole()) to be the equivalent of an empty role "" which eliminates a number of failures (for expected generic or presentational roles). If this normalization is misrepresentative I can remove.

browser

For the Cypress based suite I've made the necessary changes so that the tests run, but have not extended the suite to cover the additional accname (or other spec) tests that have been introduced since the last refresh for this setup.

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: eb37052c04a294e47b8f1ac070502ff6c42b8741

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR