fix: Use placeholder attribute as accessible name

eps1lon / dom-accessibility-api

Implements https://w3c.github.io/accname/

MIT License

102 stars 29 forks source link

fix: Use placeholder attribute as accessible name #1046

Open ymrl opened 6 months ago

ymrl commented 6 months ago

According to HTML-AAM, placeholder attribute will be used as accessible name if text-field elements (input element with some types or textarea element) do not have aria-label, aria-labelledby attributes, related label element, or title attribute.

So, I changed computeTextAlternative() function to use placeholder attribute. And to take priority for title attribute, changed to use title attribute before it.

changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: fea3a9463fe1c01dd21191b358fa312da21161c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kkoo95 commented 2 months ago

are there plans to merge this PR soon ? w3c/accname is already supporting this but we are stuck with dom-accessibility-api because we are using testing-library :(