added TracingTransport for http.Client

epsagon / epsagon-go

Automated tracing library for Go 1.x ⚡️

https://epsagon.com

MIT License

28 stars 11 forks source link

added TracingTransport for http.Client #54

Closed mgarski closed 3 years ago

mgarski commented 3 years ago

Added TracingTransport, an http.RoundTripper implementation for tracing HTTP requests
Capped metadata for the request & response bodies to 64KB each
Updated README & examples
gofmt organized the imports for the files edited

ranrib commented 3 years ago

Thanks @mgarski ! this should also fix https://github.com/epsagon/epsagon-go/pull/54 right?

mgarski commented 3 years ago

You're welcome @ranrib ! This PR resolves this issue: https://github.com/epsagon/epsagon-go/issues/14

ranrib commented 3 years ago

Quick question - since this PR breaks the existing signature, is there a way to keep both the previous way and the new Tracing transport together? @mgarski

ranrib commented 3 years ago

Quick question - since this PR breaks the existing signature, is there a way to keep both the previous way and the new Tracing transport together? @mgarski

We can also implement the backward compatibility on this PR

mgarski commented 3 years ago

@ranrib I can restore the backwards compatibility, will push a commit later today