Combining with fancyimpute

epsilon-machine / missingpy

Missing Data Imputation for Python

GNU General Public License v3.0

236 stars 63 forks source link

Combining with fancyimpute #6

Closed sergeyf closed 5 years ago

sergeyf commented 5 years ago

Hello!

I'm one of the two main authors of fancyimpute: https://github.com/iskandr/fancyimpute/tree/master/fancyimpute

We also have KNN functionality. I wonder if our two implementations overlap significantly?

fancyimpute is moderately popular, and there doesn't seem to be any other "one stop shop" for imputation algorithms. I thought it might be good to join forces. Would you consider adding whatever features you have that we don't to fancyimpute?

epsilon-machine commented 5 years ago

Hi! I am really sorry about the late response but I figured better late than never. I am indeed aware of your package and have even used it in the past. So let me first thank you for all your all your hard work on it! And as much as I would love to contribute to your package, I unfortunately do not have the bandwidth at the moment to refactor the code in this repo to make it consistent with fancyimpute's API. With that said, please continue your good work and I hope even more imputation algos get added to fancyimpute in the coming days.