epsilonlabs / emc-ptcim

EMC driver for the PTC Integrity Modeler
Eclipse Public License 1.0
2 stars 0 forks source link

Incomplete PtcimCollection.add()? #23

Closed kolovos closed 7 years ago

kolovos commented 7 years ago

In its current form, PtcimCollection.add() doesn't seem to have any effect on the underlying model (it only constructs a temporary ArrayList and adds two objects to it).

@Override
public boolean add(PtcimObject e) {
    assert e.getId() != null;
    List<Object> args = new ArrayList<Object>();
    args.add(association);
    args.add(e);
    return true;
}
zolotas4 commented 7 years ago

Remove doesn't work properly as well...

zolotas4 commented 7 years ago

Fixed in 0cfa2b13b57b00d23397c64002318ee07993150d