search

epuzanov / ZenPacks.community.DistributedCollectors

Distributed Collectors ZenPack
http://community.zenoss.org/docs/DOC-5861
GNU General Public License v2.0
13 stars 9 forks source link

masterdaemons not re-install safe for custom daemon exclusions #1

Closed dpetzel closed 12 years ago

dpetzel commented 12 years ago

If you have a custom daemon that should only run on your master (and not collectors) You have to edit ZenPacks / community / DistributedCollectors / init.py and append a daemon to the masterdaemons list on line 32. If you re-install or install an updated version as some point this will get blown away.

In my case I can see the daemons.txt file on my collectors, but no such file exists on the master.

I think this list should get persisted to $ZENHOME/etc/master_daemons.txt and then parsed using zenPath('etc'). Install method should detect this in a similar fashion to the DAEMONS_TXT_ONLY which is currently handled in the install and remove methods.

I don't mind working up a patch if desired, if your not already in the progress of updating the pack for 4.x

dpetzel commented 12 years ago

Submitted a pull request with a potential patch (There are certainly other, more sophisticated ways to tackle the issue) https://github.com/epuzanov/ZenPacks.community.DistributedCollectors/pull/2/files

epuzanov commented 12 years ago

Thanks, merged.