search

epwalsh / rust-cached-path

🦀 Rust utility for accessing both local and remote files through a unified interface
Apache License 2.0
29 stars 14 forks source link

replace `log` with `tracing` ? #62

Closed jondot closed 2 years ago

jondot commented 2 years ago

Hi, Thanks for this library, I'm using it and really enjoying the interface! Wondering if you're considering moving to tracing instead of log? it could provide more visibility, especially for this kind of scenario where you have network requests, cache, disk access, etc. If so, I feel that I could take a stab at it.

epwalsh commented 2 years ago

Hey @jondot, thanks for the kind words 🙂 I'm always happy to hear that someone is using this little library.

Tracing would be great! I did consider it before but it fell off my radar due to other priorities, so I'd love to review a PR if you want to tackle it.

jondot commented 2 years ago

great! I'll add that to my to-do list :) on a side note - I found the progress-bar wrapping which makes it Write really clever, so much that I think it can be it's own library, but -- one step at a time :)

jondot commented 2 years ago

This actually works out of the box for me (my host app uses tracing, and I see logs from rust-cached-path appearing in traces as events) So I'll close this one :)