eqasim-org / ile-de-france

An open synthetic population of Île-de-France for agent-based transport simulation
GNU General Public License v2.0
47 stars 69 forks source link

changed hardcoded crs to parametric in most scripts #219

Closed aburianne closed 6 months ago

aburianne commented 7 months ago

Three files requires specific attention from reviewer :

about CRS formatting, i proposes simple integer numerical value, compatible with : https://pyproj4.github.io/pyproj/stable/api/crs/crs.html#pyproj.crs.CRS.from_user_input

aburianne commented 7 months ago

tests\test_determinism line 74 : "ile_de_france_activities.gpkg": "4ef01c82b09e81e54cc6b7d59145123e",

I forced to crs with espg parameters, but even when reverse to initial str constant it differs un hash code. Data seams correct, any idea?

sebhoerl commented 6 months ago

Let's keep it fixed in this repository and update it on a case-by-case basis, at least for now.