fix: shuffling of primary location candidates

eqasim-org / ile-de-france

An open synthetic population of Île-de-France for agent-based transport simulation

GNU General Public License v2.0

51 stars 71 forks source link

fix: shuffling of primary location candidates #242

Closed sebhoerl closed 5 months ago

sebhoerl commented 5 months ago

I took the liberty of creating a PR that fixes #237. Running now to see if it has any impact on the unit tests.

sebhoerl commented 5 months ago

@vincent-leblond Sorry for yet another request, could you please check what impact this PR has on your flow plots? I would wait for a brief analysis from your side before merging this.

vincent-leblond commented 5 months ago

We looked at the PR with Marie. In the flow analysis, there is not much difference. It make sense as our flow analysis is done on municipalities and IRIS. However, looking at the code, we think that the PR is important to valide as it fixes a real issue.

sebhoerl commented 5 months ago

Yes, I agree. Even though you don't see a big impact, what I take from your message is that there is also no negative impact and no strange things are happening. So we can merge it :)