search

eqasim-org / matsim-sharing

MATSim extension for the simulation of shared vehicle services
GNU General Public License v2.0
4 stars 9 forks source link

incompatibility with recent MATSim #9

Open tschlenther opened 3 years ago

tschlenther commented 3 years ago

Since MATSim PR 1626, a routing module must implement calcRoute(RoutingRequest request) instead of calcRoute(Facility fromFacility, Facility toFacility, double departureTime, Person person). This means, the current version of this contribution is incompatible with MATSim versions which are more recent than PR1626, as the SharingRoutingModule needs corresponding adjustments

tschlenther commented 3 years ago

I just realised, you probably do not want to update from stable MATSim 13.0 to some current but intermediate state, like we do in some other external contribution and project repositories... However, i will probably have to combine matsim-sharing with recent MATSim myself.. i might have to come up with a fork and build locally. There are more central, relevant changes in MATSim like PR1629, that will have to get taken care of as well...

balacmi commented 3 years ago

Yeah there are a few more changes lately... Maybe what we can do is the following:

Would this work?

tschlenther commented 3 years ago

Yeah, thanks for the suggestion. If both branches would get deployed and would be usable via maven that would certainly help on the long run. For the short term however, i consider also using maven submodules for our hamburg project, as (currently) that projects only needs recent MATsim for 1 postprocess step, only.

If i'd find time to contribute here, would you like me to do that via PR from a fork?

Thanks again

sebhoerl commented 3 years ago

I would propose to move the code to matsim-libs as a contrib. @tschlenther in case you have time, feel free to move it ;) Or in any case, maybe you could coordinate with Kai if he agrees? Then I could also prepare a PR if you want

tschlenther commented 3 years ago

okay, i'll speak to him about it

tschlenther commented 3 years ago

Hi @sebhoerl i finally had the chance to talk to Kai about it: he would be happy if we could move it into matsim/contribs ! I would be super grateful if you could prepare a PR! This would be a huge help, also for moving our hamburg project forward. Thanks and all the best

sebhoerl commented 3 years ago

Ok great, I'm on holidays next week and I'll look into it after.