search

eqasim-org / synpp

Synthetic population pipeline code for eqasim
http://www.eqasim.org
MIT License
18 stars 12 forks source link

Feature/stageclasses #56

Closed davibicudo closed 3 years ago

davibicudo commented 3 years ago

This PR adresses issues #52 and #53. It doesn't cover the issues entirely however. @sebhoerl let me know what you think, perhaps you have some other ideas in mind on how to solve the same issues.

davibicudo commented 3 years ago

I was also able to use this when running arbitrary code in Jupyter. Caching worked well and devalidation as well, when the code changed (inspect.getsource seems to habe done it's job). Using "global" make it no longer robust, but may be helpful for interactive tests and caching (although IPython also has other solutions for that): image

sebhoerl commented 3 years ago

Really nice, I like the jupyter integration! It would be nice if you could add some unit tests so this is robust for the future. Thanks!

davibicudo commented 3 years ago

Sounds good, I'll increment the PR with a couple tests then.

sebhoerl commented 3 years ago

Please update the CHANGELOG.md then it should be good to go :) Thanks!