Develop add plotdir to xcorr_pick_family function

eqcorrscan / EQcorrscan

Earthquake detection and analysis in Python.

https://eqcorrscan.readthedocs.io/en/latest/

Other

166 stars 86 forks source link

Develop add plotdir to xcorr_pick_family function #325

Closed ikahbasi closed 5 years ago

ikahbasi commented 5 years ago

What does this PR do?

Develop add plotdir to xcorr_pick_family function. I hope all things be true this time. thanks.

Why was it initiated? Any relevant Issues?

PR Checklist

[x] develop base branch selected?
[x] This PR is not directly related to an existing issue (which has no PR yet).
[x] All tests still pass.
[x] Any new features or fixed regressions are be covered via new tests.
[x] Any new or changed features have are fully documented.
[x] Significant changes have been added to CHANGES.md.
[x] First time contributors have added your name to CONTRIBUTORS.md.

calum-chamberlain commented 5 years ago

If you can fix the formatting issues this should be good to go. Thanks!

You can test your formatting locally by running pep8 or flake8 on the file. Also, I like to use editors that have flake8 or pep8 plugins. PyCharm is my favourite way to work on projects like this and is free for research/teaching purposes. Otherwise Microsoft Visual Code is good too (and works on all platforms).

ikahbasi commented 5 years ago

If you can fix the formatting issues this should be good to go. Thanks!

You can test your formatting locally by running pep8 or flake8 on the file. Also, I like to use editors that have flake8 or pep8 plugins. PyCharm is my favourite way to work on projects like this and is free for research/teaching purposes. Otherwise Microsoft Visual Code is good too (and works on all platforms).

I am trying to learn how to use pep8 or flake8 now. I will fix it as soon as possible.

calum-chamberlain commented 5 years ago

Thanks so much for this @imankahbasi. I'm not sure why circleci Isn't running this, but it looks good to me.