eqcorrscan / EQcorrscan

Earthquake detection and analysis in Python.
https://eqcorrscan.readthedocs.io/en/latest/
Other
166 stars 86 forks source link

format the output-filename on template_gen.py #351

Closed Halauwet closed 5 years ago

Halauwet commented 5 years ago

Found an issue when construct template with option "plotdir" or "save_progress" on windows10, which can't use special character on the filename. So I added string format "strftime("%Y-%m-%dT%H%M%S")" for the default output-filename.

What does this PR do?

Format output filename to fix conflict with special character on windows filename

Why was it initiated? Any relevant Issues?

https://github.com/eqcorrscan/EQcorrscan/issues/344

PR Checklist

calum-chamberlain commented 5 years ago

Ace, thanks - you will need to fix the "stickler" issues before we can merge - which is just line length issues. If you have a look at the "File Changed" tab you will see comments from stickler-ci regarding what you need to do.

calum-chamberlain commented 5 years ago

@Halauwet Can you add yourself to the contributors list please (see the list of things to do in the PR template that you filled out). Can you also add a note in CHANGES.md pointing out that file naming has changed.

Otherwise this is good to go, thanks! :+1:

Halauwet commented 5 years ago

@calum-chamberlain , I have updated the CHANGES.md and CONTRIBUTORS.md. please check another commits on plotting.py it's another-same bug on plotting "cccsum"

calum-chamberlain commented 5 years ago

Please change those files in this PR, not in separate PRs.