Suppress spike_test errors and auto-clean data - Githubissues

eqcorrscan / EQcorrscan

Earthquake detection and analysis in Python.

https://eqcorrscan.readthedocs.io/en/latest/

Other

166 stars 86 forks source link

Suppress spike_test errors and auto-clean data #390

Closed ikahbasi closed 4 years ago

ikahbasi commented 4 years ago

What does this PR do?

Spike test function is not make errors anymore. With removing the spiky data the process will continue on the rest of data.

Why was it initiated? Any relevant Issues?

PR Checklist

[x] develop base branch selected?
[ ] This PR is not directly related to an existing issue (which has no PR yet).
[ ] All tests still pass.
[ ] Any new features or fixed regressions are be covered via new tests.
[ ] Any new or changed features have are fully documented.
[ ] Significant changes have been added to CHANGES.md.
[ ] First time contributors have added your name to CONTRIBUTORS.md.

calum-chamberlain commented 4 years ago

@imankahbasi I think solving this (e.g. making spike-test accurately pick up on things that will cause an issue with cross-correlation, and warning the user and optionally removing those data points) is really worthwhile, but I don't think this is the right way to do it for the reasons above - I'm going to close this PR.

I'm thinking about writing a C-function for spike-testing that effectively does the cross-correlation with one dummy template with all channels, and returns a mask to Python that can then be checked and issue locations properly reported. Unfortunately I don't have time to do this at the moment.