eqcorrscan / EQcorrscan

Earthquake detection and analysis in Python.

https://eqcorrscan.readthedocs.io/en/latest/

Other

166 stars 86 forks source link

Use min_cc regardless. #456

Closed calum-chamberlain closed 3 years ago

calum-chamberlain commented 3 years ago

What does this PR do?

Sets use of min_cc regardless of whether weight_by_correlation is set.

Why was it initiated? Any relevant Issues?

455 - this PR addresses part of this issue. Whether weighting by correlation actually returns something useful or not is still up for discussion!

PR Checklist

[x] develop base branch selected?
[x] This PR is not directly related to an existing issue (which has no PR yet).
[x] All tests still pass.
[x] Any new features or fixed regressions are be covered via new tests.
[x] Any new or changed features have are fully documented.
[x] Significant changes have been added to CHANGES.md. ~~- [ ] First time contributors have added your name to CONTRIBUTORS.md.~~

calum-chamberlain commented 3 years ago

NCEDC timeouts persist. Merging.