eqcorrscan / EQcorrscan

Earthquake detection and analysis in Python.
https://eqcorrscan.readthedocs.io/en/latest/
Other
166 stars 86 forks source link

add python version to conda env creation #465

Closed tjnewton closed 3 years ago

tjnewton commented 3 years ago

What does this PR do?

This PR adds a python version to the command to create a conda environment in the installation doc.

Why was it initiated? Any relevant Issues?

Default behavior initiates a conda environment with Python 3.9, which yields a conflict when installing EQcorrscan via conda with conda install -c conda-forge eqcorrscan:

UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:

Specifications:

  - eqcorrscan -> python[version='2.7.*|3.5.*|3.6.*|>=2.7,<2.8.0a0|>=3.6,<3.7.0a0|>=3.7,<3.8.0a0|>=3.8,<3.9.0a0|>=3.5,<3.6.0a0']

Your python: python=3.9

PR Checklist

calum-chamberlain commented 3 years ago

Thanks for that catch @tjnewton! That is really helpful - This is also a useful reminder that I need to test and package this up for Python 3.9 - I hadn't realised that the default conda python had bumped!

calum-chamberlain commented 3 years ago

Because I want this to appear in the docs ASAP I'm going to re-base this to master, and merge into develop from there. Sorry to be a pain - hopefully I can do this without needing you to change anything.

tjnewton commented 3 years ago

Sounds good. I'm happy to tweak it if needed. I'm looking forward to giving EQcorrscan a whirl!

calum-chamberlain commented 3 years ago

Bugger, I can't - @tjnewton can you make this change on a branch from master please? Or if it is annoying I can close this and make one myself?

Let me know which way you want to go - I'm also keen to see your name go on the contributors list if you want.

tjnewton commented 3 years ago

Bugger, I can't - @tjnewton can you make this change on a branch from master please? Or if it is annoying I can close this and make one myself?

Let me know which way you want to go - I'm also keen to see your name go on the contributors list if you want.

No problem, I will make the change now.