Closed Mirko-von-Leipzig closed 3 months ago
LGTM, mod:
* please add the error conversion so that header sync does not panic, I'm assuming with no bugs in the "old" header sync we could be very close to pathfinder syncing from pathfinder 🍿 * would be nice to still have the chunking in the persist stage
Fair point. My intention was to replace all of the things with SyncError2
PR-by-PR so the todo is temporary. But you're right, probably we want to actually use these things inbetween.
I'll try add them in.
@CHr15F0x I've re-added chunking - but its a manual impl, if you could sanity check it 🙏
This has lost the persistance chunking, but we can easily add that back in.