refactor: checkpoint header sync now uses stages

eqlabs / pathfinder

A Starknet full node written in Rust

https://eqlabs.github.io/pathfinder/

Other

619 stars 227 forks source link

refactor: checkpoint header sync now uses stages #2035

Closed Mirko-von-Leipzig closed 3 months ago

Mirko-von-Leipzig commented 3 months ago

This has lost the persistance chunking, but we can easily add that back in.

Mirko-von-Leipzig commented 3 months ago

LGTM, mod:

* please add the error conversion so that header sync does not panic, I'm assuming with no bugs in the "old" header sync we could be very close to pathfinder syncing from pathfinder 🍿

* would be nice to still have the chunking in the persist stage

Fair point. My intention was to replace all of the things with SyncError2 PR-by-PR so the todo is temporary. But you're right, probably we want to actually use these things inbetween.

I'll try add them in.

Mirko-von-Leipzig commented 3 months ago

@CHr15F0x I've re-added chunking - but its a manual impl, if you could sanity check it 🙏