eqlabs / pathfinder

A Starknet full node written in Rust
https://eqlabs.github.io/pathfinder/
Other
619 stars 227 forks source link

Move `PendingData` to the `Storage` crate #2038

Open Mirko-von-Leipzig opened 3 months ago

Mirko-von-Leipzig commented 3 months ago

Move the type across without making any major changes to RPC method's logic. This will include moving the watcher from RPC context to storage's transaction type.

This should hopefully be a minimally invasive change.

Finally, refactor the PendingWatcher::get(tx) accessor to a tx.pending_data() method. This will require cosmetic refactoring for the RPC methods.

Mirko-von-Leipzig commented 3 months ago

Previous issue with some other details: https://github.com/eqlabs/pathfinder/issues/1691