eqlabs / pathfinder

A Starknet full node written in Rust
https://eqlabs.github.io/pathfinder/
Other
625 stars 231 forks source link

Replace `storage::BlockId` with `common::BlockId` #2039

Open Mirko-von-Leipzig opened 4 months ago

Mirko-von-Leipzig commented 4 months ago

Should only be done after #2038 and #1738.

This will be quite a painful refactoring, but should result in less code branches within RPC methods.

Be aware that some methods might still require special handling of the pending branch. e.g. pending block headers are a subset of the full block header.

Once completed, the transaction::pending_data method should be made private which will ensure that the work is completed correctly.