P2P: fallible conversions in p2p client *_stream methods

eqlabs / pathfinder

A Starknet full node written in Rust

https://eqlabs.github.io/pathfinder/

Other

613 stars 222 forks source link

P2P: fallible conversions in p2p client *_stream methods #2101

Open CHr15F0x opened 3 weeks ago

CHr15F0x commented 3 weeks ago

These conversions are fallible right now resulting in stream termination, whereas they should either be infallible or trigger moving to the next peer.

Generally streams produced by peer_agnostic::Client::*_stream should be infallible or fail on absolutely critical errors. A malicious peer is not a critical error, it should be punished and then we move to the next peer.

CHr15F0x commented 2 weeks ago

Removing the bug label because it's a missing feature not a real bug.