search

eqlabs / pathfinder

A Starknet full node written in Rust
https://eqlabs.github.io/pathfinder/
Other
622 stars 231 forks source link

Include receipt commitment in the block header #2108

Closed CHr15F0x closed 2 months ago

CHr15F0x commented 3 months ago

And:

kkovaacs commented 2 months ago

Isn't this a duplicate of #2078?

kkovaacs commented 2 months ago

Also: is the receipt commitment for old blocks actually used anywhere else than P2P? If no, then I'd say we should just skip the migration and only populate receipt commitment for newly synced blocks.

CHr15F0x commented 2 months ago

Isn't this a duplicate of #2078?

Not really imo, that one is only about computation. Ehm with that phrasing it can be, I'll link them both and close one of them.

CHr15F0x commented 2 months ago

Also: is the receipt commitment for old blocks actually used anywhere else than P2P? If no, then I'd say we should just skip the migration and only populate receipt commitment for newly synced blocks.

Nope, no migration needed then.

CHr15F0x commented 2 months ago

Duplicate of #2078