eqlabs / pathfinder

A Starknet full node written in Rust
https://eqlabs.github.io/pathfinder/
Other
631 stars 234 forks source link

P2P: failure to propagate codec error to sync request sender #2203

Closed CHr15F0x closed 1 month ago

CHr15F0x commented 2 months ago

While syncing from Juno, if deserialization fails, the outer header stream does not bail with error. This is due to the main loop internally not forwarding the error the the outer caller if the response stream has been working correctly. This bug is repeated for each protocol type.