equalitie / ouisync-app

GNU General Public License v3.0
78 stars 9 forks source link

peers... #435

Open TheOnlyMT opened 3 months ago

TheOnlyMT commented 3 months ago

I manually added my devices in the peers tab under settings, and the files synced successfully. (Of course, the Android 7 device had to be the rebel. all Files received corrupted, mission aborted. It's like the table knew. 🙄)

I've noticed that all the devices are visible to each other in the peers tab, but they seem to be stuck in a connecting status. Excuse me, but wouldn't it make sense to display active ouisynces by names in the network? I'm curious about the reasoning behind this approach. Perhaps we could consider allowing manual device selection if automatic connection isn't viable. It would save us from entering the IP and port repeatedly...

madadam commented 3 months ago

Ouisync tries to find peers automatically using one of the peer discovery mechanisms (Local Discovery, DHT, Peer Exchange). If none of them work for some reason, the user can add the peers manually by inputting their IP address and port. After the peer is discovered (or manually added), Ouisync will automatically try to connect to them. There is however a chance that this connection might fail, due to, for example, overly restrictive NAT or firewall settings. Perhaps that's what you are experiencing?

Perhaps we could consider allowing manual device selection

As I said, after the peer is discovered, we try to connect to them automatically. Adding a manual step to this would not improve the connection chance.

entering the IP and port repeatedly...

You only need to enter it once (assuming it doesn't change), as it is persisted across restarts.

TheOnlyMT commented 3 months ago

Ouisync tries to find peers automatically using one of the peer discovery mechanisms (Local Discovery, DHT, Peer Exchange). If none of them work for some reason, the user can add the peers manually by inputting their IP address and port. After the peer is discovered (or manually added), Ouisync will automatically try to connect to them. There is however a chance that this connection might fail, due to, for example, overly restrictive NAT or firewall settings. Perhaps that's what you are experiencing?

Perhaps we could consider allowing manual device selection

As I said, after the peer is discovered, we try to connect to them automatically. Adding a manual step to this would not improve the connection chance.

entering the IP and port repeatedly...

You only need to enter it once (assuming it doesn't change), as it is persisted across restarts.

Yeah, I get it. The key thing is that after devices find each other, they just try to connect but nothing really happens. Even though they connect, after a few minutes syncing stops