Memory leak: MessageBrokers not removed from network/mod.rs/State

[inetic]

The State structure contains message_brokers: Option<HashMap<PublicRuntimeId, MessageBroker>> hash map.

Each MessageBroker should contain at least one connection to the peer with the given PublicRuntimeId, but currently we don't have a code which would remove the message broker from the hash map once all connections are closed.

This could be exploited by an adversary who would keep connecting to and disconnection from user's replica always with a different PublicRuntimeId eventually filling up the memory.

[madadam]

but currently we don't have a code which would remove the message broker from the hash map once all connections are closed.

This is not correct. We do remove the message broker when its last connection closes: https://github.com/equalitie/ouisync/blob/master/lib/src/network/mod.rs#L826

[inetic]

Hm, I missed that. You're right.