Whitelisting + cleanup + daemon threads

equalitie / swabber

Simple pubsub-based IP banning engine

7 stars 4 forks source link

Whitelisting + cleanup + daemon threads #12

Closed nosmo closed 9 years ago

nosmo commented 9 years ago

Implement both IP and network whitelisting.
Fix tests from embarassingly broken to merely inadequate. Add test for whitelisting.
Some minor housekeeping, cleaning formatting.
Set threads to be daemon threads, thereby fixing the crappy way swabber previously handled signals.

nosmo commented 9 years ago

Tagging @redwire @willdoran as I think they're the only people who can/will review python? :)

nosmo commented 9 years ago

@redwire Just a bump - pushed some commits to make thread behaviour a little less gross and in line with the behaviour we talked about off-thread.

arcrose commented 9 years ago

I've looked over the commit and it looks excellent! This is definitely a great improvement in the design. Stripping out threads if you don't need them is a win in Python.