Closed pattonwebz closed 6 months ago
@pattonwebz, are you still working on this PR since it's in draft mode?
@pattonwebz, are you still working on this PR since it's in draft mode?
I still need to work on the tests here for better coverage. If you want to review the actual code changes, that'd be great.
I plan to revisit the tests here tomorrow and the other issues assigned to me.
Moves the
edac_insert_rule_data
function to a newInsert_Rule_Data
class with a single method namedinsert
that takes the same passed params.post
actually be a\WP_Post
type rather than anobject
?).I have some thoughts about potential refactor of this function so that it can have return values that are likely to give more certainty about what has happened. My initial thought was
bool|int
and nevervoid
. With true being success, false being fail and theint
meaning it was a duplicate but would also evaluate to a truth value for checking that might be added later after it's called.Closes: #464