equalizedigital / accessibility-checker

GNU General Public License v2.0
14 stars 8 forks source link

WPCS v3.1.0 means a new rule runs on the code causing CS checks to fail #546

Closed pattonwebz closed 5 months ago

pattonwebz commented 5 months ago

Please give us a description of what happened.

WPCS v3.1.0 was released today and includes dependency updates, which means a new rule runs on the code. It caused my PR to fail in CS action here: https://github.com/equalizedigital/accessibility-checker/actions/runs/8425261393/job/23070929196?pr=545

The rule that is run on the code with the update and caused issues: Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence.MissingParentheses

This rule is useful for clarity and readability so I am going to fix the things flagged by it but we should consider if we want to pin to only patch releases in future.