Closed SteveJonesDev closed 5 months ago
@pattonwebz @SteveJonesDev
🟡 I created a new "Editor" user to test this and trigger the modal. The modal appears as expected and works in the way one might expect. However, I did observe that I was able to "Tab" out of the modal on my keyboard and that there was no focus lock. I am not sure if we can control this since I know this is an ActiveCampaign embed, but wanted to flag it.
There should be a focus trap for the modal. I'll double check it.
I can confirm the focus trap isn't working.
@SteveJonesDev I fixed that in the release branch. Can you pull and build the release branch and check if the focus trap is solved in it? https://github.com/equalizedigital/accessibility-checker/pull/596
@pattonwebz It's working for me with the latest release build. Thanks!
Instead of an interstitial page, we should add a modal on the plugin page after every activation, that includes an Active Campaign opt-in. Use the Active Campaign form currently used in the plugin. We might be able to utilize the Media upload dialog popup but we need to ensure it's accessible.