equalizedigital / accessibility-checker

GNU General Public License v2.0
15 stars 8 forks source link

Uncaught ValueError: mb_convert_encoding(): Argument #3 ($from_encoding) #570

Closed pattonwebz closed 3 months ago

pattonwebz commented 4 months ago

Please give us a description of what happened.

When a scan is performed on PHP8+ systems certain situations can result in a ValueError being thrown and it is unclear what the specific trigger for it is. This is thrown from the TextStatistics package when trying to produce the grade level.

Uncaught ValueError: mb_convert_encoding(): Argument #3 ($from_encoding)

https://wordpress.org/support/topic/uncaught-valueerror-mb_convert_encoding-argument-3-from_encoding/

Please describe what you expected to happen and why.

Scan to complete without issue and for grade level results to be available.

How can we reproduce this behavior?

It is unclear how exactly to reproduce this but the steps generally to cause it are following normal operations. However in at least one environment (or with some certain content type) it throws the error.

Technical info

pattonwebz commented 3 months ago

I have been making itterative changes to the TextStatistics package to deal with this (and other potential issues with php 8 compatability). You can see the updates in the repo here: https://github.com/equalizedigital/textstatistics

Swapping this into the plugin is just a case of defining the repo and setting the version to dev-master or some other branch that we pick on the forked repo.