search

equalizedigital / accessibility-checker

GNU General Public License v2.0
15 stars 8 forks source link

False Positives on Underline Text - not accounting for :not #577

Closed amberhinds closed 3 months ago

amberhinds commented 4 months ago

Please give us a description of what happened.

I received a report that the Accessibility Checker incorrectly flagged underlined text when text-decoration was applied to links. I believe the problem is that we're not accounting for the use of :not(). This is the specific CSS being flagged:

#main-content a:not(.et_pb_button):not(.button):not(.btn):not(.et-pb-arrow-prev):not(.et-pb-arrow-next){ text-decoration: underline; }

As you can see this is applying underline to links and this should not create an issue.

How can we reproduce this behavior?

This is the customer's website: https://fxbg.com/our-hearts-sparkle-for-these-veterans-in-fredericksburg-throughout-february/

Go to https://demosite.equalizedigital.com/wp-admin/post.php?post=780&action=edit - I added the content and CSS there so you can see the warning getting flagged.

amberhinds commented 4 months ago

I debated between a medium and low priority for this, but ultimately went for medium because I know of several users who have reported false positives on this check, including the VA. Feel free to adjust if you think it should be different @pattonwebz.

christophermhinds commented 3 months ago

@pattonwebz @SteveJonesDev

⭕️ I was not able to test this because it requires writing CSS and then scanning it, which is beyond my abilities. Posting this here as an FYI.