Closed pattonwebz closed 4 months ago
The
edac_email_optin_seen_modal
andedac_email_optin
user meta should be purged on uninstall if theedac_delete_data
option is checked in the settings.
I can add this but I will need to do it via a DB Query so I can do it in one query - and not by iterating through users. On a site with a lot of users iterating through them all and doing hundreds of database queries wouldn't be good.
We also aren't deleting post meta either, which probably should have an issue created for it, as I don't think I want to do that in this PR.
You make a good point. Let's push the deleting of the user and post meta to separate issues and come up with a good solution for that. As you said this could be a very taxing process on sites with a large number of users and posts.
This PR introduces an opt-in modal that shows on the welcome screen the first time any user visits it - providing they are not already flagged as signed up via meta created on form submit.
It does not handle redirecting users to the welcome page on activation as a recent core change made that no longer possible using the plugin activation hook. See: https://core.trac.wordpress.org/ticket/60992 We should wait for a resolution (or alternative methods for it) to that ticket before trying to add a redirect.