search

equalizedigital / accessibility-checker

GNU General Public License v2.0
15 stars 8 forks source link

Swap underlined_text rule to js scan so that we can get more accurate computed styles #586

Closed pattonwebz closed 3 months ago

pattonwebz commented 3 months ago

Adds a custom axe-core rule and checks to cover the detection from the php check for the same thing.

Moving to axe-core and JS checking allows more accurate detection of underlines because we can do computed style checks on the actually rendered content - no longer need to try and parse then figure out CSS rules and how they are applied. We get the exact styles computed for the specific element.

Fixes: #577 Fixes: #344 Fixes: #266

pattonwebz commented 3 months ago

In the interest of prepping the beta I am going to merge this without waiting on code review. This was already loosely tested but I would still appreciate code review when you have the chance.