search

equalizedigital / accessibility-checker

GNU General Public License v2.0
15 stars 8 forks source link

Use short array syntax #588

Closed pattonwebz closed 3 months ago

pattonwebz commented 3 months ago

This PR swaps to allowing short array syntax and disallowing long array syntax. It used phpcbf to auto swap the arrays around. 503 places in total.

./vendor/bin/phpcbf --sniffs=Generic.Arrays.DisallowLongArraySyntax
FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF.F.FFFF  60 / 113 (53%)
.F..FFFFF.F..F..FF...FFF.F.FFFFFFFFFFF.FF.FFFFFFFF..F        113 / 113 (100%)

PHPCBF RESULT SUMMARY
-------------------------------------------------------------------------------------------------------------
FILE                                                                                         FIXED  REMAINING
-------------------------------------------------------------------------------------------------------------
.../wp-content/plugins/accessibility-checker/includes/rules/missing_table_header.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/possible_heading.php  4      0
.../wp-content/plugins/accessibility-checker/includes/rules/long_description_invalid.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/link_blank.php  3      0
.../wp-content/plugins/accessibility-checker/includes/rules/img_alt_invalid.php  6      0
.../wp-content/plugins/accessibility-checker/includes/rules/img_alt_missing.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/color_contrast_failure.php  4      0
.../wp-content/plugins/accessibility-checker/includes/rules/link_non_html_file.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/link_improper.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/duplicate_form_label.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/img_animated_gif.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/text_small.php  3      0
.../wp-content/plugins/accessibility-checker/includes/rules/missing_lang_attr.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/link_ms_office_file.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/img_linked_alt_missing.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/img_alt_long.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/img_alt_redundant.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/tab_order_modified.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/missing_form_label.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/underlined_text.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/link_pdf.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/empty_table_header.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/slider_present.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/incorrect_heading_order.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/missing_headings.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/missing_title.php  3      0
.../wp-content/plugins/accessibility-checker/includes/rules/text_blinking_scrolling.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/empty_form_label.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/empty_link.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/broken_aria_reference.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/missing_transcript.php  4      0
.../wp-content/plugins/accessibility-checker/includes/rules/empty_heading_tag.php  3      0
.../wp-content/plugins/accessibility-checker/includes/rules/aria_hidden.php  3      0
.../wp-content/plugins/accessibility-checker/includes/rules/empty_button.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/img_alt_empty.php  2      0
.../wp-content/plugins/accessibility-checker/includes/rules/img_linked_alt_empty.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/video_present.php  4      0
.../wp-content/plugins/accessibility-checker/includes/rules/iframe_missing_title.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/text_justified.php  3      0
.../wp-content/plugins/accessibility-checker/includes/rules/broken_skip_anchor_link.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/image_map_missing_alt_text.php  1      0
.../wp-content/plugins/accessibility-checker/includes/rules/link_ambiguous_text.php  3      0
.../wp-content/plugins/accessibility-checker/includes/validate.php  13     0
.../wp-content/plugins/accessibility-checker/includes/classes/class-rest-api.php  36     0
.../wp-content/plugins/accessibility-checker/includes/classes/class-playground-check.php  1      0
.../wp-content/plugins/accessibility-checker/includes/classes/class-plugin.php  1      0
.../wp-content/plugins/accessibility-checker/includes/classes/class-accessibility-statement.php  1      0
.../wp-content/plugins/accessibility-checker/includes/classes/class-simplified-summary.php  1      0
.../wp-content/plugins/accessibility-checker/includes/classes/class-enqueue-frontend.php  1      0
.../wp-content/plugins/accessibility-checker/includes/classes/class-lazyload-filter.php  1      0
.../wp-content/plugins/accessibility-checker/includes/classes/class-edac-dom.php  8      0
.../wp-content/plugins/accessibility-checker/includes/classes/class-frontend-validate.php  1      0
.../wp-content/plugins/accessibility-checker/includes/classes/class-summary-generator.php  4      0
.../wp-content/plugins/accessibility-checker/includes/helper-functions.php  24     0
.../wp-content/plugins/accessibility-checker/includes/rules.php  43     0
.../wp-content/plugins/accessibility-checker/includes/activation.php  2      0
.../wp-content/plugins/accessibility-checker/includes/deprecated/class-scans-stats.php  2      0
.../wp-content/plugins/accessibility-checker/includes/deprecated/class-issues-query.php  3      0
.../wp-content/plugins/accessibility-checker/includes/options-page.php  15     0
.../wp-content/plugins/accessibility-checker/tests/phpunit/includes/rules/ImgAltLongTest.php  3      0
.../wp-content/plugins/accessibility-checker/tests/phpunit/includes/rules/ImgAnimatedGifTest.php  4      0
.../wp-content/plugins/accessibility-checker/tests/phpunit/includes/rules/MissingTranscriptTest.php  13     0
.../wp-content/plugins/accessibility-checker/tests/phpunit/includes/rules/AriaHiddenTest.php  16     0
.../wp-content/plugins/accessibility-checker/tests/phpunit/includes/rules/ImgAltRedundantTest.php  5      0
.../wp-content/plugins/accessibility-checker/tests/phpunit/includes/classes/SummaryGeneratorTest.php  1      0
.../wp-content/plugins/accessibility-checker/tests/phpunit/helper-functions/OrdinalTest.php  17     0
.../wp-content/plugins/accessibility-checker/tests/phpunit/helper-functions/ParseCSSTest.php  36     0
.../wp-content/plugins/accessibility-checker/tests/phpunit/helper-functions/CompareStringsTest.php  7      0
.../wp-content/plugins/accessibility-checker/tests/phpunit/Admin/HelpersTest.php  13     0
.../wp-content/plugins/accessibility-checker/tests/phpunit/Admin/PurgePostDataTest.php  6      0
.../wp-content/plugins/accessibility-checker/tests/phpunit/Admin/OptIn/EmailOptInTest.php  6      0
.../wp-content/plugins/accessibility-checker/tests/phpunit/Admin/MetaBoxesTest.php  2      0
.../wp-content/plugins/accessibility-checker/uninstall.php  1      0
.../wp-content/plugins/accessibility-checker/admin/class-admin-notices.php  11     0
.../wp-content/plugins/accessibility-checker/admin/class-widgets.php  4      0
.../wp-content/plugins/accessibility-checker/admin/class-frontend-highlight.php  3      0
.../wp-content/plugins/accessibility-checker/admin/class-accessibility-statement.php  1      0
.../wp-content/plugins/accessibility-checker/admin/class-enqueue-admin.php  6      0
.../wp-content/plugins/accessibility-checker/admin/class-ajax.php  12     0
.../wp-content/plugins/accessibility-checker/admin/class-settings.php  2      0
.../wp-content/plugins/accessibility-checker/admin/class-update-database.php  1      0
.../wp-content/plugins/accessibility-checker/admin/class-meta-boxes.php  2      0
.../wp-content/plugins/accessibility-checker/admin/class-helpers.php  1      0
.../wp-content/plugins/accessibility-checker/admin/class-insert-rule-data.php  2      0
.../wp-content/plugins/accessibility-checker/admin/class-scans-stats.php  27     0
.../wp-content/plugins/accessibility-checker/admin/class-issues-query.php  12     0
.../wp-content/plugins/accessibility-checker/admin/opt-in/class-email-opt-in.php  4      0
.../wp-content/plugins/accessibility-checker/admin/site-health/class-information.php  3      0
.../wp-content/plugins/accessibility-checker/admin/site-health/class-free.php  16     0
.../wp-content/plugins/accessibility-checker/admin/site-health/class-audit-history.php  4      0
.../wp-content/plugins/accessibility-checker/admin/site-health/class-pro.php  12     0
.../wp-content/plugins/accessibility-checker/admin/class-admin.php  2      0
.../wp-content/plugins/accessibility-checker/partials/welcome-page.php  3      0
.../wp-content/plugins/accessibility-checker/partials/settings-page.php  2      0
-------------------------------------------------------------------------------------------------------------
A TOTAL OF 503 ERRORS WERE FIXED IN 94 FILES
-------------------------------------------------------------------------------------------------------------

Time: 7.06 secs; Memory: 30MB
christophermhinds commented 3 months ago

@pattonwebz @SteveJonesDev

✅ Tested this by running a bulk scan since this PR seems to touch pretty much every rule. I understand that it's just syntax changes and not material changes to the logic. Anyway, I did not encounter any issues running the bulk scan and did not see any unusual changes to bulk scan findings (i.e. errors/warnings being reported) on the test site.