equalizedigital / accessibility-checker

GNU General Public License v2.0
15 stars 8 forks source link

Possible heading needs to support CSS variables #612

Closed amberhinds closed 1 month ago

amberhinds commented 2 months ago

Possible heading doesn't flag on paragraph tags where the font is made larger in core typography styles. See https://a11ycheckrules.wpenginepowered.com/possible-heading/

We should add support for this as a priority.

SteveJonesDev commented 2 months ago

If this is a high priority then all rules that require CSS evaluation need to have the same priority for converting them to JavaScript.

amberhinds commented 2 months ago

How common do we think CSS variables are? I think pretty common, so maybe all those rules should be converted as a high priority. Also, it means better support for core themes, which seems pretty important.

I think our rules providing highly accurate results is probably the # 1 priority because it's one of those baseline, expected things. If the plugin misses stuff compared to other tools, then savvy users won't use it.