Closed pattonwebz closed 1 month ago
as per the user-facing description of the rule, the actual PHP code was checking all elements, though
This was my mistake. We should check everything - I can edit docs.
I agree with the recommendation to reduce the character count to 200.
@amberhinds we'll open an issue to update the docs.
@amberhinds, I updated the documentation for this rule: https://equalizedigital.com/accessibility-checker/justified-text/
@pattonwebz before merging can you update the summary?
'summary' => esc_html__( 'A Text Justified warning appears in Accessibility Checker when text with more than 200 characters on your post or page is styled with justified alignment (text-align:justify). To fix this warning, remove the justified styling from the specified text elements.', 'accessibility-checker' ),
Thanks @SteveJonesDev!
This PR shifts the text_justified php rule over to a JS equivalent so that it can determine rendered/computed styles to check against.
This is currently set up to align with the description of the PHP rule but not necessarily the code of the PHP rule.
<p>
,<div>
and<td>
elements (as per the user-facing description of the rule, the actual PHP code was checking all elements, though).@amberhinds @SteveJonesDev I have two questions.
Closes: #634